Update to Bitwarden 2023.2.0 - Argon2 Encryption

Feature Requests
1

Hello,

I’ve seen Bitwarden finally implemented Argon2:

When do you think it is possible to Upgrade Vaultwarden to Version 2023.2.0?

2

Use testing, those images have it already

3

Oh cool, I didn’t know that, thank you.

I just noticed when I changed my Admin-Token a Argon2id PHC String, there was the following Messages, that doesn’t seem normal, right?

WARNING: The argon2id variable is not set. Defaulting to a blank string.
WARNING: The v variable is not set. Defaulting to a blank string.
WARNING: The m variable is not set. Defaulting to a blank string.
WARNING: The %PHC-String Part 1% variable is not set. Defaulting to a blank string.
WARNING: The %PHC-String Part 2% variable is not set. Defaulting to a blank string.

4

From the compose file specification:

You can use a $$ (double-dollar sign) when your configuration needs a literal dollar sign. This also prevents Compose from interpolating a value, so a $$ allows you to refer to environment variables that you don’t want processed by Compose.

So it seems like it’s necessary to escape the $ for docker-compose.

5

Alright, thank you, that worked. :slight_smile:

6

Or, use single quotes around the value that should also fix it.

7

I’ve tested it and I don’t think it’s enough:

root@host:/srv/test# cat docker-compose.yml 
version: "3"
services:
  test:
    image: alpine:latest
    command: printenv
    environment:
      - ADMIN_TOKEN='$argon2id$v=19$m=65540,t=3,p=4$HAexz76Lr3erFhweyNIQXt7KJcPdXLACxotExVPfxLs$i+NhxlBJib62TL+NtSzn0ZizrmtXsbirfX+/PxNI2mY'

root@host:/srv/test# docker-compose up
WARNING: The argon2id variable is not set. Defaulting to a blank string.
WARNING: The v variable is not set. Defaulting to a blank string.
WARNING: The m variable is not set. Defaulting to a blank string.
WARNING: The HAexz76Lr3erFhweyNIQXt7KJcPdXLACxotExVPfxLs variable is not set. Defaulting to a blank string.
WARNING: The i variable is not set. Defaulting to a blank string.
Starting test_test_1 ... done
Attaching to test_test_1
test_1  | PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
test_1  | HOSTNAME=2926c1079e20
test_1  | ADMIN_TOKEN='=19=65540,t=3,p=4+NhxlBJib62TL+NtSzn0ZizrmtXsbirfX+/PxNI2mY'
test_1  | HOME=/root
test_test_1 exited with code 0

It only works as expected when setting the value in an env_file.

8

Ah, yes i have it in an .env file which is used by docker-compose.
There it works indeed. Same goes for the .env file Vaultwarden uses it self.

Compose files have some strange ways of working indeed.

9

Ow, what about fully putting the variable within quotes. Like…

 - 'ADMIN_TOKEN=$argon2id$....'
10

Because of variable interpolation (which I linked above) it does not make a difference. :confused:

11

So I think we should probably add a notice to the wiki as more people will run into that issue.

12

Have you tried it?
It is handled differently i thought.

13

Same warning messages but the value is set to

ADMIN_TOKEN==19=65540,t=3,p=4+NhxlBJib62TL+NtSzn0ZizrmtXsbirfX+/PxNI2mY
14

Hmm, yea i see.
Adding some info for this is probably a good idea :slight_smile:

15

Do you know when this might graduate to the latest image?

16

There is no specific release schedule. So no.

1 Like